search

moov-io / achgateway

Payment gateway enabling automated ACH operations in a distributed and fault tolerant way.
https://moov-io.github.io/achgateway/
Apache License 2.0
54 stars 19 forks source link

gosec linter fixes #68

Closed pa3ng closed 2 years ago

pa3ng commented 2 years ago

Changes

Update: no longer going with the above approach. Will keep PR to merge gosec linter updates

Why Are Changes Being Made

codecov-commenter commented 2 years ago

Codecov Report

Merging #68 (5fe3978) into master (7dda8b7) will increase coverage by 0.03%. The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
+ Coverage   41.33%   41.37%   +0.03%     
==========================================
  Files          80       80              
  Lines        3111     3142      +31     
==========================================
+ Hits         1286     1300      +14     
- Misses       1565     1580      +15     
- Partials      260      262       +2
Impacted Files Coverage Δ
internal/incoming/odfi/admin.go 0.00% <0.00%> (ø)
internal/pipeline/manual_cutoff_times.go 0.00% <0.00%> (ø)
internal/shards/repository.go 57.89% <58.33%> (-0.44%) :arrow_down:
internal/environment.go 50.00% <100.00%> (+2.99%) :arrow_up:
internal/incoming/web/api_files.go 76.81% <100.00%> (+3.93%) :arrow_up:
internal/pipeline/file_receiver.go 22.58% <0.00%> (-11.83%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7dda8b7...5fe3978. Read the comment docs.