search

moov-io / achgateway

Payment gateway enabling automated ACH operations in a distributed and fault tolerant way.
https://moov-io.github.io/achgateway/
Apache License 2.0
54 stars 19 forks source link

output: support CR+LF line endings #81

Closed adamdecaf closed 2 years ago

adamdecaf commented 2 years ago

This change supports supplying "windows" line endings for ACH files that are uploaded. It only works for NACHA encoded files and their base64 transformations.

codecov-commenter commented 2 years ago

Codecov Report

Merging #81 (a8df8c5) into master (975d435) will increase coverage by 0.17%. The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   40.78%   40.95%   +0.17%     
==========================================
  Files          88       88              
  Lines        3499     3511      +12     
==========================================
+ Hits         1427     1438      +11     
- Misses       1792     1795       +3     
+ Partials      280      278       -2
Impacted Files Coverage Δ
internal/output/format.go 26.31% <21.42%> (-0.96%) :arrow_down:
internal/output/nacha.go 71.42% <80.00%> (+21.42%) :arrow_up:
internal/output/base64.go 81.81% <100.00%> (+1.81%) :arrow_up:
internal/upload/sftp.go 65.04% <0.00%> (+2.42%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 975d435...a8df8c5. Read the comment docs.