moov-io / achgateway

Payment gateway enabling automated ACH operations in a distributed and fault tolerant way.
https://moov-io.github.io/achgateway/
Apache License 2.0
54 stars 19 forks source link

pipeline: save ValidateOpts alongside each file for later merging #84

Closed adamdecaf closed 2 years ago

adamdecaf commented 2 years ago

Changes

This set of changes is useful for passing along ach.ValidateOpts with files to better allow custom fields/values to be shipped to ODFIs.

Why Are Changes Being Made

Some ODFI's and platforms require custom field values and prior to these changes those are not fully supported.

Related Changes

See https://github.com/moov-io/ach/pull/993 for more details

codecov-commenter commented 2 years ago

Codecov Report

Merging #84 (6ffdb85) into master (2ab8223) will increase coverage by 0.42%. The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   41.04%   41.47%   +0.42%     
==========================================
  Files          88       88              
  Lines        3525     3537      +12     
==========================================
+ Hits         1447     1467      +20     
+ Misses       1799     1785      -14     
- Partials      279      285       +6     
Impacted Files Coverage Δ
internal/pipeline/merging.go 28.23% <84.61%> (+10.51%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2ab8223...6ffdb85. Read the comment docs.