search

moov-io / achgateway

Payment gateway enabling automated ACH operations in a distributed and fault tolerant way.
https://moov-io.github.io/achgateway/
Apache License 2.0
52 stars 19 forks source link

pipeline: support passing ach merge conditions through #94

Closed adamdecaf closed 2 years ago

adamdecaf commented 2 years ago

This allows Shards to further control merged file behavior, such as max dollar amounts per-file.

The change as-is will be a small breaking change. Flattening batches (and these merge conditions) should be configured on a shard level. Currently they're on a global level, but each ODFI is different.

See: https://github.com/moov-io/ach/pull/1009

codecov-commenter commented 2 years ago

Codecov Report

Merging #94 (7f434a1) into master (9ccdc11) will decrease coverage by 0.30%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
- Coverage   42.11%   41.80%   -0.31%     
==========================================
  Files          87       87              
  Lines        3633     3636       +3     
==========================================
- Hits         1530     1520      -10     
- Misses       1809     1822      +13     
  Partials      294      294
Impacted Files Coverage Δ
internal/pipeline/merging.go 27.32% <0.00%> (-0.46%) :arrow_down:
internal/service/model_sharding.go 7.01% <ø> (ø)
internal/service/model_upload.go 44.32% <ø> (ø)
internal/schedule/cutoff.go 68.62% <0.00%> (-23.53%) :arrow_down:
internal/upload/sftp.go 66.03% <0.00%> (+0.94%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9ccdc11...7f434a1. Read the comment docs.