search

moov-io / bai2

BAI2 file format is a cash management balance reporting standard
Apache License 2.0
18 stars 9 forks source link

[api] /format endpoint returns JSON-encoded BAI2 file #100

Closed wokkaflokka closed 7 months ago

wokkaflokka commented 7 months ago

This change proposes a new endpoint for the BAI2 server that validates a BAI2 file and returns a JSON structure of the file. The returned JSON matches the structure that this library uses internally to represent a BAI2 file.

adamdecaf commented 7 months ago

The build failure is fixed in newer OpenAPI versions. If we're going to release a bigger change I'm okay forcing a newer openapi-generator as well. Thoughts?

wokkaflokka commented 7 months ago

@adamdecaf I am fine making that upgrade here if you are.

wokkaflokka commented 7 months ago

@adamdecaf I updated OpenAPI to 7.4.0.

The generator generated a new test file named pkg/client/test/api_bai2_files_test.go that I manually deleted from source. I looked for an option to disable generating this test for now, but didn't find one, so would expect this to come back on next generation.

Keeping and running the test would be fine, but it includes a templated Git URL that requires additional configuration / was leading to test failure locally.

adamdecaf commented 7 months ago

Sounds good. Thanks!