Closed omerlh closed 2 months ago
@omerlh can you run gofmt -s -w
on that main.go file?
Yeah sure!
Sorry I missed this before but we don't want to be passing booleans around. I thought you were talking about an Options struct that goes on a BAI2 File, Reader, Writer, ValidateWith(...) which has an IgnoreVersion bool
field.
This change would be a breaking change as-is and booleans make for bad parameters.
I am happy to change the code to support options parameters, but it needs to be populated from the CLI args... Also we can do that non-breaking with default values
@omerlh I moved ignoreVersion to an Options struct. Thoughts?
Looking good!
As discussed on #118 that's for supporting weird BAI files with wrong header 🤷