search

moov-io / fincen

Fincen BSA E-Filing forms
https://moov-io.github.io/fincen/
Apache License 2.0
20 stars 7 forks source link

fix: fincen requies a 2 (ein) for 30 and 34 which is reporting financ… #44

Closed mimy2001 closed 1 year ago

mimy2001 commented 1 year ago

According to the SAR XML User Guide, both 30/34 require 2 (ein) instead of 4(tin)

Attaching screenshots to demonstrate this:

Screen Shot 2022-11-14 at 10 35 48 AM
adamdecaf commented 1 year ago

@mimy2001 can you fixup the tests?

cc @mfdeveloper508

mfdeveloper508 commented 1 year ago

The document is for CTR (https://bsaefiling.fincen.treas.gov/docs/XMLUserGuide_FinCENCTR.pdf) the code is for SAR (https://github.com/moov-io/fincen/pull/44/files#diff-7c77360ca152cb4960e9bfd745711fc7fea5f00f56ecb8d6d7814777b6f33facL251)

adamdecaf commented 1 year ago

Right, so should we close this PR?

mimy2001 commented 1 year ago

@adamdecaf I couldn't figure out how to fix the tests, let me attach again. I might have accidentally attached the wrong screenshot for one. There's two screenshots, the second one is definitely for SAR because when i upload to fincen it complains. Can you tell me how to run the tests locally? I'll get new screenshots

mimy2001 commented 1 year ago
Screen Shot 2022-11-15 at 5 40 06 PM Screen Shot 2022-11-15 at 5 39 49 PM

From these screenshots you can see that this is for the SAR user guide and 30 and 34 both say required is 2 and not 4.

mfdeveloper508 commented 1 year ago

right, the package had a code refactoring so created new PR https://github.com/moov-io/fincen/pull/47

mimy2001 commented 1 year ago

I'll close this one.