moov-io / fincen

Fincen BSA E-Filing forms
https://moov-io.github.io/fincen/
Apache License 2.0
20 stars 7 forks source link

fix: fincen needs the order of party account association to have part… #48

Closed mimy2001 closed 1 year ago

mimy2001 commented 1 year ago

When we added the PartyAccountAssociationType to Subject, fincen is rejecting the XML saying that party account association type code is in the wrong position.

According to the FINCENSAR user guide sample -> this element should be ahead of the Party

Screen Shot 2022-11-23 at 10 57 07 AM
mfdeveloper508 commented 1 year ago

thanks @mimy2001 I don't know fincen is rejecting the xml

adamdecaf commented 1 year ago

Some xml parsers/validators require the elements in a specific order, which is annoying.

adamdecaf commented 1 year ago

Thanks @mimy2001 for fixing this! Do you need a tagged release, or can you go get the latest commit?

mimy2001 commented 1 year ago

i think i can go get the latest commit :) let me give it a try

mimy2001 commented 1 year ago

forgot to attch the screenshot of the error I got at fincen I'll put it up now

Screen Shot 2022-11-23 at 3 56 08 PM
mimy2001 commented 1 year ago

was able to pull from the commit @adamdecaf thanks!