search

moov-io / fincen

Fincen BSA E-Filing forms
https://moov-io.github.io/fincen/
Apache License 2.0
20 stars 7 forks source link

fix: need to add in cash out codes for currency transaction activity … #87

Closed mimy2001 closed 9 months ago

mimy2001 commented 10 months ago

Cash out codes are missing for currency transaction activity detail type

Screenshot 2024-01-04 at 5 08 49 PM
codecov-commenter commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (adb21d0) 73.79% compared to head (c013fe1) 73.74%.

:exclamation: Current head c013fe1 differs from pull request most recent head 006873a. Consider uploading reports for the commit 006873a to get more accurate results

Files Patch % Lines
pkg/currency_transaction/primitive.go 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #87 +/- ## ========================================== - Coverage 73.79% 73.74% -0.05% ========================================== Files 17 17 Lines 1698 1699 +1 ========================================== Hits 1253 1253 - Misses 386 387 +1 Partials 59 59 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mimy2001 commented 10 months ago

@adamdecaf Hey Adam, i don't have any options to merge this, is that new? I can't remember last time if I got an approval I can just push the code straight in or is it due to the code coverage bot above?

adamdecaf commented 9 months ago

Did we give you commit access to the repo? Usually a Moov employee reviews the code and merges when it looks good.

mimy2001 commented 9 months ago

ah ok :) i probably just remembered wrong, it's been a while since I've pushed a new fix. But I just put up another PR today.