search

moov-io / imagecashletter

X9’s Specifications for ICL (Image Cash Letter) to provide Check 21 services. The HTTP server is available in a Docker image and the Go package is available.
https://moov-io.github.io/imagecashletter/
Apache License 2.0
60 stars 39 forks source link

cashLetterControl: settlement date should not be mandatory #319

Closed atonks2 closed 1 year ago

atonks2 commented 1 year ago

The current validation logic treats CashLetterControl.SettlementDate as mandatory under certain conditions, but the specifications say this field "Shall be present only under clearing arrangements". Removing this field requirement allows this library to support a wider variety of Image Cash Letter formats.

codecov-commenter commented 1 year ago

Codecov Report

Merging #319 (aabb367) into master (0435ccd) will increase coverage by 0.03%. The diff coverage is 72.72%.

:exclamation: Current head aabb367 differs from pull request most recent head e7c9e11. Consider uploading reports for the commit e7c9e11 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #319 +/- ## ========================================== + Coverage 87.82% 87.86% +0.03% ========================================== Files 36 36 Lines 5028 5028 ========================================== + Hits 4416 4418 +2 + Misses 405 404 -1 + Partials 207 206 -1 ```