moov-io / imagecashletter

X9’s Specifications for ICL (Image Cash Letter) to provide Check 21 services. The HTTP server is available in a Docker image and the Go package is available.
https://moov-io.github.io/imagecashletter/
Apache License 2.0
63 stars 39 forks source link

Files api v2 #345

Closed atonks2 closed 8 months ago

atonks2 commented 8 months ago

This PR starts a new /v2/files/* API to introduce enhanced functionality without any breaking changes. The first new endpoint is a new version of the Create File endpoint.

In the current implementation, switching between ASCII and EBCDIC uploads requires a code change, which means new Docker image and deployment. The new version makes better use of Content-Type and Accept headers to support the following with no code or configuration updates:

codecov-commenter commented 8 months ago

Codecov Report

Merging #345 (2d1df49) into master (9575bfd) will increase coverage by 10.07%. The diff coverage is 73.33%.

:exclamation: Current head 2d1df49 differs from pull request most recent head 8fc9513. Consider uploading reports for the commit 8fc9513 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #345 +/- ## =========================================== + Coverage 74.08% 84.15% +10.07% =========================================== Files 41 39 -2 Lines 6034 5415 -619 =========================================== + Hits 4470 4557 +87 + Misses 1291 576 -715 - Partials 273 282 +9 ```