search

moov-io / iso8583-connection

:satellite: Go-powered ISO8583 connection handler offering advanced binary framing, message interleaving, and a robust connection pool for load distribution and seamless reconnections.
Apache License 2.0
62 stars 22 forks source link

Define how we extract requestID #40

Closed jerome-laforge closed 1 year ago

jerome-laforge commented 1 year ago

According to you, is it acceptable if I propose an PR where the requestID (currently given by https://github.com/moov-io/iso8583-connection/blob/fe9f74e6dba24076c443e23b10afff99b32e7e5a/connection.go#L457) can be overwritten via an option?

and by default, only stan will be used as requestID.

alovak commented 1 year ago

Not sure I understand the question, but this PR lets you to override how you generate request ID: https://github.com/moov-io/iso8583-connection/pull/39

jerome-laforge commented 1 year ago

Sorry, I miss this PR, but this is exactly what I am looking for :) So i am waiting for a merge of this PR :)

Thanks again for your support

jerome-laforge commented 1 year ago

closed with #39

many thx

alovak commented 1 year ago

here it is: https://github.com/moov-io/iso8583-connection/releases/tag/v0.3.2

alovak commented 1 year ago

@jerome-laforge join #iso8583 channel here https://slack.moov.io/ we can discuss different things/ideas/issues/approaches there if you want.