search

moov-io / iso8583

A golang implementation to marshal and unmarshal iso8583 message.
https://moov.io
Apache License 2.0
349 stars 103 forks source link

Documentation, Typed vs unTyped is confusing #142

Closed wadearnold closed 2 years ago

wadearnold commented 2 years ago

Combine the typed and untyped sections together. There should be an intro for why you would want to use Typed vs Untyped spec's in this library.

alovak commented 2 years ago

@wade, I've updated the documentation a little bit. I hope that now it's clear when and why.

Here you can check it: https://github.com/moov-io/iso8583#setting-values-of-individual-fields

Please, let me know if something is missing.

wadearnold commented 2 years ago

This looks really good. My only suggestion would be to give an example of implementing data for a field vs a rawfile.

alovak commented 2 years ago

Not sure I understand :) Maybe you can give me an example?

wadearnold commented 2 years ago

I apologize. I had two tabs open and read the message.Marshal(data) instead of the updated readme. Please ignore.

alovak commented 2 years ago

I'll close the issue then! Thanks for reading the docs and noticing the issues! :D