codecov-commenter
commented
2 years ago :warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 51.85185% with 26 lines in your changes missing coverage. Please review.
Project coverage is 70.91%. Comparing base (
92f3b34) to head (dd4a723). Report is 120 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #185 +/- ## ========================================== + Coverage 70.50% 70.91% +0.41% ========================================== Files 37 38 +1 Lines 1773 1798 +25 ========================================== + Hits 1250 1275 +25 - Misses 334 336 +2 + Partials 189 187 -2 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Resolves #103
Introduce a
SafeErrortype (credits to @alovak for the idea!) which is used to wrap around external errors, preventing the returned error message from displaying sensitive information, while still allowing errors to be matched. Use this new error type to wrap external errors in thefieldandencodingpackages, as these operate on the potentially sensitive data.I considered also wrapping external errors in the
prefixandnetworkpackages, but since these only operate on the length part of the data, exposing their details should be okay (as long as the message is correctly formatted).