moov-io / iso8583

A golang implementation to marshal and unmarshal iso8583 message.
https://moov.io
Apache License 2.0
353 stars 105 forks source link

fix slice bounds of range; add fuzzing #218

Closed alovak closed 1 year ago

alovak commented 1 year ago

With this PR we added fuzzing for message.Unpack. The PR closes #216 and #217

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.09 :tada:

Comparison is base (53dbe42) 73.10% compared to head (8d2dd38) 73.19%.

:exclamation: Current head 8d2dd38 differs from pull request most recent head c003fee. Consider uploading reports for the commit c003fee to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #218 +/- ## ========================================== + Coverage 73.10% 73.19% +0.09% ========================================== Files 40 40 Lines 1963 1981 +18 ========================================== + Hits 1435 1450 +15 - Misses 320 321 +1 - Partials 208 210 +2 ``` | [Impacted Files](https://codecov.io/gh/moov-io/iso8583/pull/218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io) | Coverage Δ | | |---|---|---| | [encoding/ascii.go](https://codecov.io/gh/moov-io/iso8583/pull/218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-ZW5jb2RpbmcvYXNjaWkuZ28=) | `89.47% <0.00%> (-10.53%)` | :arrow_down: | | [encoding/bertlv.go](https://codecov.io/gh/moov-io/iso8583/pull/218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-ZW5jb2RpbmcvYmVydGx2Lmdv) | `91.30% <ø> (ø)` | | | [field/composite.go](https://codecov.io/gh/moov-io/iso8583/pull/218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-ZmllbGQvY29tcG9zaXRlLmdv) | `80.09% <0.00%> (-0.77%)` | :arrow_down: | | [encoding/hex.go](https://codecov.io/gh/moov-io/iso8583/pull/218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-ZW5jb2RpbmcvaGV4Lmdv) | `87.09% <50.00%> (-5.50%)` | :arrow_down: | | [encoding/bcd.go](https://codecov.io/gh/moov-io/iso8583/pull/218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-ZW5jb2RpbmcvYmNkLmdv) | `100.00% <100.00%> (ø)` | | | [encoding/binary.go](https://codecov.io/gh/moov-io/iso8583/pull/218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-ZW5jb2RpbmcvYmluYXJ5Lmdv) | `30.00% <100.00%> (+30.00%)` | :arrow_up: | | [encoding/ebcdic.go](https://codecov.io/gh/moov-io/iso8583/pull/218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-ZW5jb2RpbmcvZWJjZGljLmdv) | `100.00% <100.00%> (ø)` | | | [encoding/ebcdic1047.go](https://codecov.io/gh/moov-io/iso8583/pull/218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-ZW5jb2RpbmcvZWJjZGljMTA0Ny5nbw==) | `76.47% <100.00%> (+3.13%)` | :arrow_up: | | [encoding/lbcd.go](https://codecov.io/gh/moov-io/iso8583/pull/218?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-ZW5jb2RpbmcvbGJjZC5nbw==) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://codecov.io/gh/moov-io/iso8583/pull/218/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.