moov-io / iso8583

A golang implementation to marshal and unmarshal iso8583 message.
https://moov.io
Apache License 2.0
304 stars 100 forks source link

Vertical align multi-line byte blocks #240

Closed adamkornafeld closed 1 year ago

adamkornafeld commented 1 year ago

What:

Example:

ISO 8583 Message:
MTI..........: 0800
Bitmap HEX...: 82200000000000020C00000020000000
Bitmap bits..:
    [1-8]10000010    [9-16]00100000   [17-24]00000000   [25-32]00000000
  [33-40]00000000   [41-48]00000000   [49-56]00000000   [57-64]00000010
  [65-72]00001100   [73-80]00000000   [81-88]00000000   [89-96]00000000
 [97-104]00100000 [105-112]00000000 [113-120]00000000 [121-128]00000000

-------------------------------------------

Bitmap HEX...: 800000
Bitmap bits..:
[1-8]10000000 [9-16]00000000 [17-24]00000000

It's a breaking change:

alovak commented 1 year ago

@adamkornafeld thanks for such a great improvement!!!

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.04 :tada:

Comparison is base (158dce8) 73.88% compared to head (2c9ac96) 73.92%.

:exclamation: Current head 2c9ac96 differs from pull request most recent head 3b75a54. Consider uploading reports for the commit 3b75a54 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #240 +/- ## ========================================== + Coverage 73.88% 73.92% +0.04% ========================================== Files 42 42 Lines 2236 2240 +4 ========================================== + Hits 1652 1656 +4 Misses 353 353 Partials 231 231 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/moov-io/iso8583/pull/240/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.