Closed alovak closed 11 months ago
Patch coverage: 75.00%
and project coverage change: +0.05%
:tada:
Comparison is base (
026d31c
) 73.43% compared to head (93bf5ae
) 73.49%. Report is 1 commits behind head on master.:exclamation: Current head 93bf5ae differs from pull request most recent head 105736b. Consider uploading reports for the commit 105736b to get more accurate results
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
In the spec I'm working with now, there is a max length for BerTLV fields.
Currently, we are ignoring the
Length
(max length) of the field spec forprefix.BerTLV
. This PR changes the prefix a little bit:Length
is set to0
or is not set (0
is zero value used for theLength
anyway) - we do not check max length - this is to support current integrations which, most probably, follow the example from our tests like this:Length
is set to non-zero value, perform the checkThis PR is a breaking change (potentially) if you use the
prefix.BerTLV
and set non-zeroLength
in the field spec.