Extend the Header interface with Name()

moov-io / iso8583

A golang implementation to marshal and unmarshal iso8583 message.

https://moov.io

Apache License 2.0

352 stars 105 forks source link

Extend the Header interface with Name() #267

Closed PumpkinSeed closed 1 year ago

PumpkinSeed commented 1 year ago

Resolve #144

Added the Name() method for the Header interface
Implement the missing method for the structs implement the Header

alovak commented 1 year ago

@PumpkinSeed May I ask you to share some context about your use case for headers and Name?

I'm asking because I think that we should move headers into https://github.com/moov-io/iso8583-connection -> headers package

PumpkinSeed commented 1 year ago

Well, I opened the issue board and I saw the #144. So I thought I resolve this issue by adding this. That's my use-case for now. I'm just trying to understand the library, because we have a basic iso8583 package. I think the best way to understand something is via contributions.

alovak commented 1 year ago

@PumpkinSeed thanks for the context! I had to close that ticket so no one would take it. Sorry.

this package is focused on message building and parsing. For networking, which includes headers, we have a separate repository https://github.com/moov-io/iso8583-connection. So, I want to move headers there. But it will be a breaking change... so I tried to postpone it...

PumpkinSeed commented 1 year ago

Make sense, thanks for the update.