moov-io / iso8583

A golang implementation to marshal and unmarshal iso8583 message.
https://moov.io
Apache License 2.0
304 stars 100 forks source link

[Draft] Remove existing panics in the code #270

Closed PumpkinSeed closed 10 months ago

PumpkinSeed commented 10 months ago

I would like to start a discussion PR about the possible implementation of #269.

As the first part I would like to remove the panic from the sort package. I did it by modifying the function signature of the StringSlice. This is an incomplete implementation because I didn't add the error handling on the caller side, but if we can agree on this, I can start to do the changes.