SetData is there to support compatibility with our first version of Marshal/Unmarshal implementation. In this PR I described why using Data and SetData was not good. In short, it has some side effects such as linking objects using pointers.
The following should be done:
get rid of the data struct field in all fields of the field package (String, Numeric, etc.)
move code from SetData to Marshal
deprecate SetData method
This change should not break any integrations unless they still use the version with the Data() method that was deprecated and deleted.
alovak
commented
9 months ago
SetDatais there to support compatibility with our first version of Marshal/Unmarshal implementation. In this PR I described why usingDataandSetDatawas not good. In short, it has some side effects such as linking objects using pointers.The following should be done:
datastruct field in all fields of thefieldpackage (String,Numeric, etc.)SetDatatoMarshalSetDatamethodThis change should not break any integrations unless they still use the version with the
Data()method that was deprecated and deleted.