search

moov-io / iso8583

A golang implementation to marshal and unmarshal iso8583 message.
https://moov.io
Apache License 2.0
304 stars 100 forks source link

Support new tag `iso8583` in addition to `index` #281

Closed alovak closed 8 months ago

alovak commented 10 months ago

Using tag index was not a good idea, typically, tags named as json, xml, sql. In the context of this package, it should be named iso8583. Also, when we add more attributes to the tag like "3,keepzero", the name index does not make any sense.

We should support the following: Amount intiso8583:"3,keepzero"and keepindex` for compatibility.

POC for this is implemented here: https://github.com/moov-io/iso8583/pull/273/files

GalihFajar commented 9 months ago

hi @alovak I'd like to work on this issue (I'm currently delving into the repository so can't promise much 🙇 ).

alovak commented 9 months ago

@GalihFajar afaik @mfdeveloper508 is working on this issue. You can look at this issue: https://github.com/moov-io/iso8583/issues/292. It doesn't require many changes, and it seems like a good choice for the first issue.

GalihFajar commented 9 months ago

Thanks @alovak, will look onto that one

alovak commented 8 months ago

closed in #293