search

moov-io / iso8583

A golang implementation to marshal and unmarshal iso8583 message.
https://moov.io
Apache License 2.0
352 stars 105 forks source link

deprecate setdata method for fields, update unmarshal/marshal functions #287

Closed mfdeveloper508 closed 1 year ago

mfdeveloper508 commented 1 year ago

https://github.com/moov-io/iso8583/issues/279 https://github.com/moov-io/iso8583/issues/280 https://github.com/moov-io/iso8583/issues/278 https://github.com/moov-io/iso8583/issues/282

codecov-commenter commented 1 year ago

Codecov Report

Attention: 91 lines in your changes are missing coverage. Please review.

Comparison is base (b05481c) 73.95% compared to head (ffade70) 73.45%.

:exclamation: Current head ffade70 differs from pull request most recent head 0485485. Consider uploading reports for the commit 0485485 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #287 +/- ## ========================================== - Coverage 73.95% 73.45% -0.50% ========================================== Files 43 43 Lines 2338 2494 +156 ========================================== + Hits 1729 1832 +103 - Misses 378 420 +42 - Partials 231 242 +11 ``` | [Files](https://app.codecov.io/gh/moov-io/iso8583/pull/287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io) | Coverage Δ | | |---|---|---| | [field/bitmap.go](https://app.codecov.io/gh/moov-io/iso8583/pull/287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-ZmllbGQvYml0bWFwLmdv) | `69.29% <33.33%> (-1.76%)` | :arrow_down: | | [field/track3.go](https://app.codecov.io/gh/moov-io/iso8583/pull/287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-ZmllbGQvdHJhY2szLmdv) | `61.79% <33.33%> (ø)` | | | [field/track1.go](https://app.codecov.io/gh/moov-io/iso8583/pull/287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-ZmllbGQvdHJhY2sxLmdv) | `69.02% <40.00%> (ø)` | | | [field/track2.go](https://app.codecov.io/gh/moov-io/iso8583/pull/287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-ZmllbGQvdHJhY2syLmdv) | `68.22% <40.00%> (ø)` | | | [message.go](https://app.codecov.io/gh/moov-io/iso8583/pull/287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-bWVzc2FnZS5nbw==) | `74.13% <71.42%> (-0.77%)` | :arrow_down: | | [field/composite.go](https://app.codecov.io/gh/moov-io/iso8583/pull/287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-ZmllbGQvY29tcG9zaXRlLmdv) | `78.70% <57.14%> (-2.09%)` | :arrow_down: | | [field/hex.go](https://app.codecov.io/gh/moov-io/iso8583/pull/287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-ZmllbGQvaGV4Lmdv) | `72.72% <71.15%> (+4.18%)` | :arrow_up: | | [field/string.go](https://app.codecov.io/gh/moov-io/iso8583/pull/287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-ZmllbGQvc3RyaW5nLmdv) | `76.72% <67.92%> (-6.41%)` | :arrow_down: | | [field/binary.go](https://app.codecov.io/gh/moov-io/iso8583/pull/287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-ZmllbGQvYmluYXJ5Lmdv) | `65.07% <66.66%> (+4.40%)` | :arrow_up: | | [field/numeric.go](https://app.codecov.io/gh/moov-io/iso8583/pull/287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-ZmllbGQvbnVtZXJpYy5nbw==) | `78.74% <64.91%> (-4.41%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alovak commented 1 year ago

@mfdeveloper508 thanks for the PR! I'll review it soon!

mfdeveloper508 commented 1 year ago

The PR separate into https://github.com/moov-io/iso8583/pull/288, https://github.com/moov-io/iso8583/pull/289, https://github.com/moov-io/iso8583/pull/290