search

moov-io / iso8583

A golang implementation to marshal and unmarshal iso8583 message.
https://moov.io
Apache License 2.0
304 stars 100 forks source link

Update message unimarshaller functions #291

Closed mfdeveloper508 closed 9 months ago

mfdeveloper508 commented 9 months ago

https://github.com/moov-io/iso8583/issues/282

codecov-commenter commented 9 months ago

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (ec6abff) 74.91% compared to head (a257d96) 74.75%.

:exclamation: Current head a257d96 differs from pull request most recent head 1103771. Consider uploading reports for the commit 1103771 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #291 +/- ## ========================================== - Coverage 74.91% 74.75% -0.17% ========================================== Files 43 43 Lines 2436 2452 +16 ========================================== + Hits 1825 1833 +8 - Misses 389 396 +7 - Partials 222 223 +1 ``` | [Files](https://app.codecov.io/gh/moov-io/iso8583/pull/291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io) | Coverage Δ | | |---|---|---| | [message.go](https://app.codecov.io/gh/moov-io/iso8583/pull/291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-bWVzc2FnZS5nbw==) | `74.13% <71.42%> (+0.02%)` | :arrow_up: | | [field/composite.go](https://app.codecov.io/gh/moov-io/iso8583/pull/291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-ZmllbGQvY29tcG9zaXRlLmdv) | `78.70% <57.14%> (-1.43%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alovak commented 9 months ago

It looks good! Would you please add table tests for Marshal/Unmarshal something like this: https://github.com/moov-io/iso8583/blob/2f44c9f5c9bf72927313d35e4dfaa478711943fb/exp_test.go?

mfdeveloper508 commented 9 months ago

I will append exp_test.go in next pr