Update Numeric type to use int64

GalihFajar commented 9 months ago

This pull request addresses issue #292

alovak commented 9 months ago

@GalihFajar thanks for the PR! It looks great!

codecov-commenter commented 8 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (cd4f442) 74.64% compared to head (7a58491) 74.64%.

:exclamation: Current head 7a58491 differs from pull request most recent head 868ce25. Consider uploading reports for the commit 868ce25 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #294 +/- ## ======================================= Coverage 74.64% 74.64% ======================================= Files 43 43 Lines 2465 2465 ======================================= Hits 1840 1840 Misses 400 400 Partials 225 225 ``` | [Files](https://app.codecov.io/gh/moov-io/iso8583/pull/294?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io) | Coverage Δ | | |---|---|---| | [field/numeric.go](https://app.codecov.io/gh/moov-io/iso8583/pull/294?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=moov-io#diff-ZmllbGQvbnVtZXJpYy5nbw==) | `87.06% <93.75%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alovak commented 8 months ago

@GalihFajar I appreciate your help with the issue! Great job! Thank you one more time!!! I'm going to release a new version of the package in the next few days, your change will be included in that release.

GalihFajar commented 8 months ago

@alovak thank you sir, happy to help!

moov-io / iso8583

Update Numeric type to use int64 #294

Codecov Report