search

moov-io / paygate

A RESTful API enabling electronic payments to be submitted and received without a deep understanding payment file specification
http://moov.io
Apache License 2.0
129 stars 31 forks source link

use base lib GetSkipAndCount method. Also replace offset/limit with s… #574

Closed jmbrown412 closed 3 years ago

jmbrown412 commented 3 years ago

This PR replaces offset and limit with skip and count and uses the base method GetSkipAndCount() to get the values from the http request.

codecov-commenter commented 3 years ago

Codecov Report

Merging #574 into master will increase coverage by 0.12%. The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #574      +/-   ##
==========================================
+ Coverage   50.91%   51.04%   +0.12%     
==========================================
  Files          93       93              
  Lines        3121     3123       +2     
==========================================
+ Hits         1589     1594       +5     
+ Misses       1184     1181       -3     
  Partials      348      348
Impacted Files Coverage Δ
pkg/transfers/router.go 57.14% <75.00%> (+0.45%) :arrow_up:
pkg/transfers/repository.go 66.83% <100.00%> (ø)
pkg/database/sqlite.go 50.87% <0.00%> (+5.26%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b15d2c...5b9fec6. Read the comment docs.

InfernoJJ commented 3 years ago

It was just a discussion over the naming in the API that made the most sense for how we want to handle paging going forward across all the API's