search

moov-io / paygate

A RESTful API enabling electronic payments to be submitted and received without a deep understanding payment file specification
http://moov.io
Apache License 2.0
129 stars 31 forks source link

deleting empty files based on config #612

Closed jmbrown412 closed 3 years ago

jmbrown412 commented 3 years ago

This PR introduces logic to conditionally delete zero byte (empty) files that may exist on the remote server while a transfer is in place. We want to wait to delete these after a configurable amount of time.

codecov-io commented 3 years ago

Codecov Report

Merging #612 into master will increase coverage by 0.21%. The diff coverage is 74.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
+ Coverage   51.73%   51.94%   +0.21%     
==========================================
  Files          95       95              
  Lines        3236     3267      +31     
==========================================
+ Hits         1674     1697      +23     
- Misses       1211     1216       +5     
- Partials      351      354       +3
Impacted Files Coverage Δ
pkg/config/odfi.go 30.00% <ø> (ø)
pkg/transfers/inbound/scheduler.go 44.18% <0.00%> (-2.16%) :arrow_down:
pkg/transfers/inbound/cleanup.go 76.00% <79.31%> (+4.57%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 23a24c5...638e2da. Read the comment docs.

adamdecaf commented 3 years ago

This looks really good @jmbrown412, nice job!