moov-io / paygate

A RESTful API enabling electronic payments to be submitted and received without a deep understanding payment file specification
http://moov.io
Apache License 2.0
129 stars 31 forks source link

api,client: include 412 "precondition failed" from idempotency key checks #614

Closed adamdecaf closed 4 years ago

adamdecaf commented 4 years ago

@joshsadler asked about this today. We didn't specify it in our docs.

codecov-io commented 4 years ago

Codecov Report

Merging #614 into master will decrease coverage by 0.11%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #614      +/-   ##
==========================================
- Coverage   51.84%   51.73%   -0.12%     
==========================================
  Files          95       95              
  Lines        3227     3236       +9     
==========================================
+ Hits         1673     1674       +1     
- Misses       1202     1211       +9     
+ Partials      352      351       -1     
Impacted Files Coverage Δ
pkg/transfers/inbound/prenotes.go 30.43% <0.00%> (-4.57%) :arrow_down:
x/trace/trace.go 92.59% <0.00%> (-3.57%) :arrow_down:
x/route/route.go 83.78% <0.00%> (-1.94%) :arrow_down:
pkg/config/config.go 61.53% <0.00%> (-1.43%) :arrow_down:
pkg/validation/microdeposits/router.go 66.30% <0.00%> (-0.37%) :arrow_down:
pkg/transfers/pipeline/aggregate.go 12.92% <0.00%> (-0.09%) :arrow_down:
cmd/server/main.go 9.23% <0.00%> (ø)
pkg/transfers/inbound/cleanup.go 71.42% <0.00%> (ø)
pkg/transfers/pipeline/merging.go 10.20% <0.00%> (ø)
pkg/transfers/inbound/scheduler.go 46.34% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d5a132c...3d0cd8b. Read the comment docs.