Closed alovak closed 3 years ago
Build seems to be failing, looks like a race condition.
Merging #615 (49472fa) into master (3c763df) will decrease coverage by
0.29%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #615 +/- ##
==========================================
- Coverage 51.73% 51.44% -0.30%
==========================================
Files 95 92 -3
Lines 3249 3077 -172
==========================================
- Hits 1681 1583 -98
+ Misses 1218 1168 -50
+ Partials 350 326 -24
Impacted Files | Coverage Δ | |
---|---|---|
x/route/route.go | 88.57% <100.00%> (+4.78%) |
:arrow_up: |
pkg/transfers/pipeline/notify/mock_sender.go | 0.00% <0.00%> (-66.67%) |
:arrow_down: |
pkg/transfers/pipeline/notify/multi.go | 0.00% <0.00%> (-42.86%) |
:arrow_down: |
pkg/upload/sftp.go | 63.42% <0.00%> (-2.86%) |
:arrow_down: |
pkg/transfers/pipeline/aggregate.go | 12.92% <0.00%> (+0.17%) |
:arrow_up: |
pkg/transfers/pipeline/notify/email.go | 63.49% <0.00%> (+1.37%) |
:arrow_up: |
x/schedule/cutoff.go | 86.66% <0.00%> (+49.99%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3c763df...8c9cbe4. Read the comment docs.
With this PR we are replacing
paygate/pkg/database
withmoov-io/base/database
package. Major changes are:/migrations
directory where all migrations are stored/migrations
directory, we have to embed the/migrations
directory into go-file before we build server binary withmake embed-migrations
.@adamdecaf instructions to update Paygate's DB are the same as for Customer's.