search

moov-io / paygate

A RESTful API enabling electronic payments to be submitted and received without a deep understanding payment file specification
http://moov.io
Apache License 2.0
129 stars 31 forks source link

transfers/pipeline: break out of async loop on Subscription shutdown #622

Closed adamdecaf closed 3 years ago

adamdecaf commented 3 years ago

This was reported by a community member where on shutdown the log is filled with "FailedPrecondition" messages as this loop keeps iterating until the underlying process is killed.

codecov-io commented 3 years ago

Codecov Report

Merging #622 (cf54f05) into master (274711c) will decrease coverage by 0.03%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #622      +/-   ##
==========================================
- Coverage   51.73%   51.69%   -0.04%     
==========================================
  Files          95       95              
  Lines        3236     3238       +2     
==========================================
  Hits         1674     1674              
- Misses       1211     1213       +2     
  Partials      351      351
Impacted Files Coverage Δ
pkg/transfers/pipeline/aggregate.go 12.75% <0.00%> (-0.18%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 274711c...cf54f05. Read the comment docs.