search

moov-io / paygate

A RESTful API enabling electronic payments to be submitted and received without a deep understanding payment file specification
http://moov.io
Apache License 2.0
129 stars 31 forks source link

Allowing processor to handle files downloaded to root of temp dir #642

Closed theFong closed 3 years ago

theFong commented 3 years ago

The ProcessFile function assumes all children of downloadedFiles.dir are directories. This PR no longer makes that assumption by checking if it is a file or dir and handling accordingly.

codecov-io commented 3 years ago

Codecov Report

Merging #642 (feee2f8) into master (c9cf626) will decrease coverage by 0.12%. The diff coverage is 33.33%.

:exclamation: Current head feee2f8 differs from pull request most recent head 4bc7561. Consider uploading reports for the commit 4bc7561 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #642      +/-   ##
==========================================
- Coverage   52.51%   52.38%   -0.13%     
==========================================
  Files          95       95              
  Lines        3304     3295       -9     
==========================================
- Hits         1735     1726       -9     
+ Misses       1210     1209       -1     
- Partials      359      360       +1
Impacted Files Coverage Δ
pkg/transfers/inbound/processor.go 45.45% <33.33%> (+0.29%) :arrow_up:
pkg/upload/sftp.go 64.86% <0.00%> (-2.71%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c9cf626...4bc7561. Read the comment docs.