search

moov-io / rtp20022

ISO20022 messages in Go for Real Time Payments (RTP)
Apache License 2.0
40 stars 9 forks source link

rtp: expose serial generator as a function, with helpers #61

Closed adamdecaf closed 4 months ago

adamdecaf commented 4 months ago

I've adapted the two below PR's into a more general approach and added it for every serial function.

See https://github.com/moov-io/rtp20022/pull/59 and https://github.com/moov-io/rtp20022/pull/60

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.65%. Comparing base (8d3bebe) to head (c1c66b0).

:exclamation: Current head c1c66b0 differs from pull request most recent head c8db072. Consider uploading reports for the commit c8db072 to get more accurate results

Files Patch % Lines
pkg/rtp/serials.go 87.50% 1 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #61 +/- ## ========================================== + Coverage 84.42% 84.65% +0.22% ========================================== Files 13 13 Lines 199 215 +16 ========================================== + Hits 168 182 +14 - Misses 26 27 +1 - Partials 5 6 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.