search

moov-io / wire

FedWire funds service file parser and writer. The HTTP server is available in a Docker image and the Go package is available.
https://moov-io.github.io/wire/
Apache License 2.0
83 stars 39 forks source link

fix parse error with max length #316

Closed mfdeveloper508 closed 1 year ago

mfdeveloper508 commented 1 year ago

Error case

parseVariableStringField has a problem when parsing field with max length

What does this pull request do?

codecov-commenter commented 1 year ago

Codecov Report

Merging #316 (1c3bf6b) into master (fe3bc08) will decrease coverage by 0.05%. The diff coverage is 44.44%.

:exclamation: Current head 1c3bf6b differs from pull request most recent head 7be8c7b. Consider uploading reports for the commit 7be8c7b to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #316 +/- ## ========================================== - Coverage 74.88% 74.84% -0.05% ========================================== Files 73 73 Lines 8637 8639 +2 ========================================== - Hits 6468 6466 -2 - Misses 1595 1597 +2 - Partials 574 576 +2 ```
adamdecaf commented 1 year ago

Can we make sure any printf calls are removed like https://github.com/moov-io/wire/issues/321 mentions?

mfdeveloper508 commented 1 year ago

wire project has a lot of debug messages using fmt.printf let me make sure output messages