search

moov-io / wire

FedWire funds service file parser and writer. The HTTP server is available in a Docker image and the Go package is available.
https://moov-io.github.io/wire/
Apache License 2.0
83 stars 39 forks source link

api: expose file.isIncoming as a query param #355

Closed atonks2 closed 11 months ago

atonks2 commented 11 months ago

The file.isIncoming flag wasn't being honored consistently between files created via JSON or file upload. Additionally, writing an incoming file without SenderSupplied would fail because the writer wasn't checking isIncoming.

This change makes it possible to explicitly specify isIncoming on file creation via query param, and honors the flag in all subsequent requests (get file, get file contents, etc.).

codecov-commenter commented 11 months ago

Codecov Report

Merging #355 (356139d) into master (71d51ac) will decrease coverage by 0.02%. The diff coverage is 72.72%.

:exclamation: Current head 356139d differs from pull request most recent head 8654fe9. Consider uploading reports for the commit 8654fe9 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #355 +/- ## ========================================== - Coverage 74.85% 74.84% -0.02% ========================================== Files 73 73 Lines 8653 8657 +4 ========================================== + Hits 6477 6479 +2 - Misses 1609 1611 +2 Partials 567 567 ```