Bug found in Authentication Service

moov2 / Orchard.ActiveDirectoryAuthorization

Module for Orchard CMS that handles authorization for active directory users.

19 stars 15 forks source link

Bug found in Authentication Service #5

Closed Excommunicated closed 11 years ago

Excommunicated commented 11 years ago

Found thousands of these in the Error logs . 2013-02-14 16:05:16,313 [220] Orchard.ContentManagement.DefaultContentManager - NullReferenceException thrown from IContentHandler by Orchard.Core.Common.Handlers.CommonPartHandler System.NullReferenceException: Object reference not set to an instance of an object. at ActiveDirectoryAuthorization.Services.ActiveDirectoryAuthenticationService.GetAuthenticatedUser() at ....

peterkeating commented 11 years ago

We came across this yesterday also! :)

Will get this checked out and merge this weekend.

Cheers!

peterkeating commented 11 years ago

Merged in. I also added a null reference check on the HttpContext.Current.User as I was still getting the exceptions appearing in the log. Looks like that has solved it.

Thanks again your contributions have been great :)