search

moovweb / gvm

Go Version Manager
http://github.com/moovweb/gvm
MIT License
9.91k stars 522 forks source link

Update README.md #335

Closed BenKnigge closed 4 years ago

BenKnigge commented 4 years ago

I'm unable to approve my own pr. If anyone is willing to review it would be appreciated.

BenKnigge commented 4 years ago

Thanks, you were suggested as someone to review. I've taken over as maintainer of this project and am looking to work my way through the existing issues and make a few minor improvements moving forward.

theball commented 4 years ago

Ishan, We should give Benjamin full ability to review and approve PRs.

On Mon, Feb 3, 2020 at 8:50 AM Benjamin F Knigge notifications@github.com wrote:

Thanks, you were suggested as someone to review. I've taken over as maintainer of this project and am looking to work my way through the existing issues and make a few minor improvements moving forward.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/moovweb/gvm/pull/335?email_source=notifications&email_token=AAAPZKFNKLGQ26HJ6TS25OTRBBDONA5CNFSM4KO7UPX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKUR6ZQ#issuecomment-581508966, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPZKDM2VA4CBGVHTJSWJLRBBDONANCNFSM4KO7UPXQ .

BenKnigge commented 4 years ago

I have the ability to approve PR's just not the ability to approve my own. I'm going to be looking at re-enabling travis as well and am not sure if I have the proper permissions to do that.

Thanks,

Ben

On Mon, Feb 3, 2020 at 9:53 AM Ajay Kapur notifications@github.com wrote:

Ishan, We should give Benjamin full ability to review and approve PRs.

On Mon, Feb 3, 2020 at 8:50 AM Benjamin F Knigge <notifications@github.com

wrote:

Thanks, you were suggested as someone to review. I've taken over as maintainer of this project and am looking to work my way through the existing issues and make a few minor improvements moving forward.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub < https://github.com/moovweb/gvm/pull/335?email_source=notifications&email_token=AAAPZKFNKLGQ26HJ6TS25OTRBBDONA5CNFSM4KO7UPX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKUR6ZQ#issuecomment-581508966 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAAPZKDM2VA4CBGVHTJSWJLRBBDONANCNFSM4KO7UPXQ

.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/moovweb/gvm/pull/335?email_source=notifications&email_token=ACJHMF7QIQ7LEMGW4QN4D2DRBBDYZA5CNFSM4KO7UPX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKUSI2I#issuecomment-581510249, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJHMFZEE2IYZQCOQ7WGRCDRBBDYZANCNFSM4KO7UPXQ .

-- Benjamin Knigge Ben@Heptec.com tel: +1-310-570-2880

ianand commented 4 years ago

@BenKnigge I requested to give you admin access or the highest possible. let me know if you run into permissions issues.

ianand commented 4 years ago

From our IT team:

[W]hat he seems to be running into was a master branch limit. I removed all limitations on master branch PRs; please have him try again.

BenKnigge commented 4 years ago

Thanks

On Mon, Feb 3, 2020, 2:00 PM Ishan Anand notifications@github.com wrote:

From our IT team:

[W]hat he seems to be running into was a master branch limit. I removed all limitations on master branch PRs; please have him try again.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/moovweb/gvm/pull/335?email_source=notifications&email_token=ACJHMF22IZTC2UZ6EU2ARK3RBCAWJA5CNFSM4KO7UPX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKVMBXY#issuecomment-581615839, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJHMF6R7PEPTNXFTA7OW2LRBCAWJANCNFSM4KO7UPXQ .