search

moovweb / gvm

Go Version Manager
http://github.com/moovweb/gvm
MIT License
9.91k stars 522 forks source link

When updating source always download the tags #354

Closed pmalek closed 11 months ago

pmalek commented 3 years ago

When upgrading to go1.15 on Mac (using git version 2.28.0) I've noticed that I keep getting Unrecognized Go version.

It appeared that latest master - ed2c95b - uses git pull without --tags which doesn't download tags on my machine, hence not finding the requested version (not sure how it worked before).

With this PR I suggest to add --tags to git pull there so that tags are always downloaded.

Maybe this will fix https://github.com/moovweb/gvm/issues/160

BenKnigge commented 11 months ago

please resolve conflicts

pmalek commented 11 months ago

@BenKnigge Done! Thanks for taking a look at it 🙇