moovweb / gvm

Go Version Manager
http://github.com/moovweb/gvm
MIT License
10.18k stars 533 forks source link

Replaces egrep with grep -E in gvm_export_path function #432

Open clcollins opened 1 year ago

clcollins commented 1 year ago

egrep is listed as deprecated and in Fedora 38, is outputting the message "warning: egrep is obsolescent". According to #431, the official release notes from Grep 3.8 state egrep has been deprecated since 2007.

This PR replaces egrep in gvm_export_path with grep -E.

egrep is mentioned in a couple of the files in ./examples/native/, but as I don't think they're critical to the use of GVM, I have not attempted to replace them.

Fixes #431

Signed-off-by: Chris Collins collins.christopher@gmail.com

BenKnigge commented 1 year ago

please resolve conflicts

clcollins commented 1 year ago

Apologies @BenKnigge , I missed your message. I've rebased and fixed the conflict.

dannywillems commented 11 months ago

I'm in favor of having this merged.

sergio222-dev commented 3 months ago

is this going to be merged?