moovweb / gvm

Go Version Manager
http://github.com/moovweb/gvm
MIT License
9.87k stars 520 forks source link

invert if statements that could cause a unexpected short circuits #470

Open josephcopenhaver opened 3 months ago

josephcopenhaver commented 3 months ago

If the code is running in a shell or non interactive environment with set -eo pipefail called previously then one-line shorthand-form if statements that have no false path handle will bubble an error up immediately. Much of the code does not expect for this flag to be set.

I scrubbed through the scripts pretty quick and used De Morgans' law to adjust them.

I'm pretty sure the main issue my installer is having is around "./scripts/gvm-default" specifically when running source "$HOME/.gvm/scripts/gvm" if this looks too dense.

I also left lines like [[ -s "$HOME/.gvm/scripts/gvm" ]] && source "$HOME/.gvm/scripts/gvm" alone because it's technically a line present on people's rc files and pattern matching that is performed would need to be adjusted.

Thanks for your consideration.