search

moovweb / gvm

Go Version Manager
http://github.com/moovweb/gvm
MIT License
10.37k stars 545 forks source link

Fix incorrect path reformatting issue #488

Open Heunsig opened 3 months ago

Heunsig commented 3 months ago

I have fixed an issue in the __gvm_munge_path() function located in the ~/.gvm/scripts/function/munge_path file. Previously, paths containing spaces were being incorrectly parsed, leading to problems such as /AppData/Local/Programs/Microsoft:VS:Code/bin:/snap/bin, where colons (:) were inserted into the path names.

Because of this, after installing gvm, some terminal commands would result in a "command not found" error.

To resolve this, I updated the script to enclose each path in double quotes ("") when adding them to the array. This ensures paths with spaces are handled correctly.

This fix should solve the following issues: https://github.com/moovweb/gvm/issues/486#issue-2433874341, https://github.com/moovweb/gvm/issues/487#issue-2444729848, https://github.com/moovweb/gvm/issues/466#issue-2165852612

pmhofman-se commented 1 month ago

Can we please get this merged?

Heunsig commented 1 month ago

Can we please get this merged?

Looks like the main contributor hasn't had a chance to review this yet

pmhofman-se commented 3 weeks ago

Has this repo been abandonned when Edgio took over Moov?? Maybe better continue with a fork then....