search

moovweb / tritium

Tritium is a magical document modifying language. It's JavaScript-like and simple to learn. Think XSLT without the nightmare. It was designed by Hampton Catlin (@hcatlin), and has been heavily influenced by Aaron Leung (@akhleung).
http://tritium.io
Mozilla Public License 2.0
33 stars 7 forks source link

Latest Tritium (0.2.43) crashes Asda #1

Closed tdesikan closed 13 years ago

tdesikan commented 13 years ago

Versions

Gems:

manhattan (0.2.210)
socorro (0.1.5)
tritium (0.2.43)
quadrium (0.1.9)

Asda Script:

tag: TESTED_31
aka githash: 43a10eb

Action

I cleared by browser's cookies and cache And then hit: http://mlocal.groceries.asda.com/asda-estore/index.jsp?referrer=cookiesDetecting

Result

I get a big fat error

stack level too deep

/home/tarun/.rvm/gems/ruby-1.9.2-p180/gems/tritium-0.2.43/lib/parser/instruction.rb:72

Ignorant Comments

Looks like an issue with the latest version of Tritium. Could be elsewhere too.

HamptonMakes commented 13 years ago

Fixed in tritium 0.2.44

You can just upgrade tritium to fix the issue.

Sorry! It was a side-effect of the earlier fix.

-hampton.

On Thu, May 19, 2011 at 7:21 PM, tdesikan < reply@reply.github.com>wrote:

Versions

Gems:

manhattan (0.2.210) socorro (0.1.5) tritium (0.2.43) quadrium (0.1.9)

Asda Script:

tag: TESTED_31 aka githash: 43a10eb

Action

I cleared by browser's cookies and cache And then hit: http://mlocal.groceries.asda.com/asda-estore/index.jsp?referrer=cookiesDetecting

Result

I get a big fat error

stack level too deep

/home/tarun/.rvm/gems/ruby-1.9.2-p180/gems/tritium-0.2.43/lib/parser/instruction.rb:72

Ignorant Comments

Looks like an issue with the latest version of Tritium. Could be elsewhere too.

Reply to this email directly or view it on GitHub: https://github.com/moovweb/tritium/issues/1

tdesikan commented 13 years ago

Thanks HC.

when i run "rvmsudo moov server ." i no longer get the error.

however, i usually run "rvmsudo moov debug ." ... that's what i was running when i reported the error. and i still get it with the latest version.

same repro as above.

stack level too deep

/home/tarun/.rvm/gems/ruby-1.9.2-p180@latest/gems/tritium-0.2.44/lib/parser/instruction.rb:72
tdesikan commented 13 years ago

I'm reopening this issue because im still seeing it.

Happens on Debug, not on Server.

HamptonMakes commented 13 years ago

Ah! Yeah, part of every error report needs to be the engine you were using.

HamptonMakes commented 13 years ago

Ah! I found the issue.

In the home.ts script, there is this line:

move_to("/html/body/div[@id='mw_mainWrapper']", top)

You'll notice that top doesn't have quotes around it. This caused all sorts of havoc.

I have added a check to Tritium where it makes sure that if something like top() is passed in as an argument, it will throw a (half decent) error for tracking it down.

But, this is really a bug in ASDA. I will fix it now.

tdesikan commented 13 years ago

Shweeet.