search

mooyoul / serverless-latest-layer-version

A serverless plugin that replaces 'latest' version tag to actual lambda layer version
MIT License
25 stars 9 forks source link

Fix conflict with serverless-pseudo-parameters plugin #4

Closed laszlominczer closed 4 years ago

andrepintorj commented 5 years ago

This is a nice fix since a lot of people seem to use serverless-pseudo-parameters plugin...

barendb commented 4 years ago

~Yo @mooyoul any update on this? Would really like to see this being published.~

piohhmy commented 4 years ago

Hi @mooyoul I also would love to see this get merged and published!

codyfazio commented 4 years ago

@mooyoul Any chance of getting this approved and merged? Would also really like to see this published!

barendb commented 4 years ago

PS: I tested this fix using patch-package and didn't work for me.

I don't the problem is how the parts of the ARN is extracted, but at what stage of the Serverless lifecycle the plugin runs and wether is using the right "replaced config". Hope that makes sense, I ran out of time trying to figure it out.

mooyoul commented 4 years ago

Hello all. I rewrote almost all codes (resolving/replacing layer version related logic) and New version just published to npm!

Please try out new version of serverless-latest-layer-version plugin and please let me know the results :) Thanks for your patience!

barendb commented 4 years ago

Tested and works like a charm! Thanks @mooyoul really appreciate it! ❤️

piohhmy commented 4 years ago

Thanks @mooyoul !

mooyoul commented 4 years ago

Glad to hear it works 🎉 If this plugin helped you, Don't forget to give a star ;) Thanks!