search

mooz / js2-mode

Improved JavaScript editing mode for GNU Emacs
GNU General Public License v3.0
1.32k stars 186 forks source link

Support mocha-like test files in Imenu #576

Closed DamienCassou closed 2 years ago

DamienCassou commented 2 years ago

Closes #575.

dgutov commented 2 years ago

Solid effort :+1:. Could you rebase it on master now?

dgutov commented 2 years ago

A NEWS entry would be nice to have, too.

DamienCassou commented 2 years ago

I took care of your feedback but there are issues with the tests in 25.1. Do you have any idea?

dgutov commented 2 years ago

but there are issues with the tests in 25.1. Do you have any idea?

Looks like when-let* was not in Emacs 25. I think if you just change it to when-let, everything will work.

DamienCassou commented 2 years ago

Looks like when-let* was not in Emacs 25. I think if you just change it to when-let, everything will work.

Indeed. I also had to require "subr-x". I also added Emacs 26.3 to GitHub Actions because it also needs "subr-x".

dgutov commented 2 years ago

Thanks!

DamienCassou commented 2 years ago

Thank you for your reviews and the package!