mooz / keysnail

Allows you to bind commands to key sequences in Mozilla Firefox
http://wiki.github.com/mooz/keysnail
701 stars 56 forks source link

bmany: Support Firefox 40 #180

Closed gardejo closed 9 years ago

gardejo commented 9 years ago

Hello,

It seems like bmany plug-in has a few following problems on recent (40+) Firefoxes. This Pull Request tries to solve them.

I would be grateful if you could merge it. Thank you for your cooperation.

1. Bookmark properties dialog

bmany cannot invoke Bookmark properties dialog by Edit selected bookmark item menu item (edit-bookmark command). It is because PlacesUIUtils.showBookmarkDialog() now takes a node of places, not an node#itemId.

See also:

bmany doubly opens a URI in a list item.

I am awfully sorry but I am not find out its fundamental cause. But the latest KeySnail 2.7.0-signed only supports Firefox 34 to 41. So I simply removed the compatibility codes for legacy Firefoxes.

3. Fallback for keywords

Regrettably, Firefox 40+ removes the keywords column from the library. So I simply added fallback codes.

See also:

From the very beginning (198bfd26feb497a6b053e112d64abce9e5864caf), we had been mistaken the condition of the cache exists or not. So I fixed it.

mooz commented 9 years ago

Wow! Thanks for the great contribution. I'll bump up the version.

gardejo commented 9 years ago

I am grateful to have you handle that right away. And I am sorry to have omitted consideration of minVersion in PLUGIN_INFO.