mooz / xkeysnail

Yet another keyboard remapping tool for X environment
890 stars 112 forks source link

Please do not ignore process name #154

Open axrdiv opened 2 years ago

axrdiv commented 2 years ago

Hi, thanks for your software. In some cases, I need to know the process name, which was ignored by get_activate_window_wm_class() in transform.py. 2022-03-01_10-41 Please consider change the return value. 2022-03-01_10-50

luizoti commented 2 years ago

Be wrong, but I think I'm thinking of doing, eb52b7fb9fd459ba8237ed2f2a9da9e79699859e, you can test and confirm, if it works for you.

joshgoebel commented 2 years ago

In some cases, I need to know the process name, which was ignored by

It's not ignored... if they both match it just avoids the duplication by condensing it to a single string... what am I missing here?

joshgoebel commented 2 years ago

@axrdiv What is your specific use case where you need to check the name? An example and knowing what those window names look like would help.

axrdiv commented 2 years ago

In some cases, I need to know the process name, which was ignored by

It's not ignored... if they both match it just avoids the duplication by condensing it to a single string... what am I missing here?

The original source code can be found in here: code

You can use xprop command to check window's WM_CLASS info, it consists of instance name and class name two values, they are different some time. stackexchange

luizoti commented 2 years ago

In some cases, I need to know the process name, which was ignored by

It's not ignored... if they both match it just avoids the duplication by condensing it to a single string... what am I missing here?

The original source code can be found in here: code

You can use xprop command to check window's WM_CLASS info, it consists of instance name and class name two values, they are different some time. stackexchange

But in which cases? Because the name is not always the same as the class, and as far as I remember the code does not use the name at any time.