search

mooz / xkeysnail

Yet another keyboard remapping tool for X environment
900 stars 112 forks source link

Exit when last device disconnects only when when watching is disabled #86

Closed luizoti closed 1 year ago

luizoti commented 4 years ago

Based on #63

Lenbok commented 4 years ago

I don't understand how this helps you. Your earlier comment on 70a45f0639b8 was about xkeysnail not detecting when you remove and re-add your "Sony PS3 BD Remote". With this PR, it just means exactly the same thing would happen if you also have another keyboard plugged in (since xkeysnail would stay running) and then plug in your Sony remote.

In other words, instead of this patch, you should fix the actual underlying problem: Why is the bluetooth keyboard not being detected while xkeysnail stays running.

(edit: found where the comment was made)

luizoti commented 4 years ago

When I reconnect the xkeysnail is re-executed, via udev, I even prefer it, because when the control is disconnected I don't need the xkeysnail running.

As I said, it can only be related to bluetooth, but I don't know.

OBVIOUSLY, if xkeysnail recognizes control when reconnected, this is better behavior, but doing so is beyond my capabilities.

This correction allows the user to freely choose the behavior that best suits them.

Lenbok commented 4 years ago

The thing is, your patch does not appear to fix your issue in the general case, since if you have any extra keyboards (or remotes) plugged in, xkeysnail won't exit (it's only exiting if the last device disconnects).

I haven't seen anyone running xkeysnail via udev before - is that described somewhere? Can you share how you are doing that? Is it even being invoked with --watch (which is required for adding devices on re-connect)?

luizoti commented 4 years ago

The thing is, your patch does not appear to fix your issue in the general case, since if you have any extra keyboards (or remotes) plugged in, xkeysnail won't exit (it's only exiting if the last device disconnects).

It also makes sense to me, but it never worked like that and since I never needed more than 1 control, in fact, even for keyboards I use, just for this control, it was never a problem.

--watch

I tested this option, but it doesn't recognize the control as I said above, in fact, it maps my notebook keyboard, so I use a script to directly point the path /dev/input, the problem probably hangs in that area. This operation makes sense to me, but as it occurs, it does not currently occur, looking at the script and verifying that the storage device arrives if it uses X or Y keys, my control from what I note is based on the keyboard, but there is no like keys on a keyboard.

I haven't seen anyone running xkeysnail via udev before

I use use udev rules.