moozzyk / SignalR-Client-Swift

Swift SignalR Client for Asp.Net Core SignalR server
MIT License
356 stars 136 forks source link

Got a new type of crash when I upgraded from 0.8.0 to 0.9.1 #278

Closed ammarmarn closed 1 year ago

ammarmarn commented 1 year ago

I am getting crash reports for this crash in SignalR client after I updated the client from 0.8.0 to 0.9.1. So its a fresh issue, before I never got any crash in SignalR client itself. I am attaching the screenshot of Firebase crashlytics stack trace. I didn't faced it in development but users are facing this issue. I feel its related to some 'keepalive' property usage etc.

Xcode: 14.2 iOS Versions: Users reported crash using ios versions from 15.6.1 till 16.3.1 Device: iPad (as app is intended for iPad users only)

Screenshot 2023-03-30 at 2 40 03 PM Screenshot 2023-03-30 at 2 42 31 PM
moozzyk commented 1 year ago

This is a dupe of #264 and #270 which was fixed in 0.9.2

HalitGumus commented 1 year ago

Even though we are using the latest version (1.0.0 tag), we are experiencing crashes on devices with iOS 17. @moozzyk

Screenshot 2023-09-21 at 10 45 28 AM

Screenshot 2023-09-21 at 10 48 01 AM

moozzyk commented 1 year ago

Unfortunately, these screenshots don't have enough details to tell what's going on. Please provide logs at the debug level and the stack trace.

ahmetcanerbay commented 1 year ago

Hi, @moozzyk i am teammate with @HalitGumus in this project and we didn't faced it in development but users are facing this issue that whose OS version is iOS 17. So we will try to provide logs at the debug level asap, but the stack trace logs of a crash from crashlytics that @HalitGumus is shared as ss are here:

Crashed: com.apple.main-thread 0 JTAppleCalendar 0x26ba8 $s15JTAppleCalendar15JTACMonthLayoutC21setupDataFromDelegateyyF + 1020 1 JTAppleCalendar 0x265fc $s15JTAppleCalendar15JTACMonthLayoutC7prepareyyF + 396 2 JTAppleCalendar 0x2679c $s15JTAppleCalendar15JTACMonthLayoutC7prepareyyFTo + 28 3 UIKitCore 0x1309d4 -[UICollectionViewData _prepareToLoadData] + 100 4 UIKitCore 0x12db5c -[UICollectionViewData validateLayoutInRect:] + 100 5 UIKitCore 0x7a84c -[UICollectionView layoutSubviews] + 220 6 JTAppleCalendar 0x22584 $s15JTAppleCalendar13JTACMonthViewC14layoutSubviewsyyF + 48 7 JTAppleCalendar 0x22698 $s15JTAppleCalendar13JTACMonthViewC14layoutSubviewsyyFTo + 28 8 UIKitCore 0x331d8 -[UIView(CALayerDelegate) layoutSublayersOfLayer:] + 1528 9 QuartzCore 0x67888 CA::Layer::layout_if_needed(CA::Transaction) + 500 10 QuartzCore 0x67410 CA::Layer::layout_and_display_if_needed(CA::Transaction) + 144 11 QuartzCore 0x6d94c CA::Context::commit_transaction(CA::Transaction, double, double) + 464 12 QuartzCore 0x66c3c CA::Transaction::commit() + 648 13 QuartzCore 0x668e4 CA::Transaction::flush_as_runloop_observer(bool) + 88 14 UIKitCore 0xab27c _UIApplicationFlushCATransaction + 52 15 UIKitCore 0xaad94 _UIUpdateSequenceRun + 84 16 UIKitCore 0xaa484 schedulerStepScheduledMainSection + 144 17 UIKitCore 0xaa540 runloopSourceCallback + 92 18 CoreFoundation 0x37acc CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION + 28 19 CoreFoundation 0x36d48 CFRunLoopDoSource0 + 176 20 CoreFoundation 0x354fc CFRunLoopDoSources0 + 244 21 CoreFoundation 0x34238 __CFRunLoopRun + 828 22 CoreFoundation 0x33e18 CFRunLoopRunSpecific + 608 23 GraphicsServices 0x35ec GSEventRunModal + 164 24 UIKitCore 0x22f350 -[UIApplication _run] + 888 25 UIKitCore 0x22e98c UIApplicationMain + 340 26 Hiwell 0x6fec main + 21 (AppDelegate.swift:21) 27 ??? 0x1d5dc3d44 (Missing)

moozzyk commented 1 year ago

@ahmetcanerbay This stack trace appears to be from the main thread. I couldn't find there a single frame coming from SignalR there. As such it is not helpful to diagnose the crash.

HalitGumus commented 1 year ago

@moozzyk hi,

When we examined the logs in detail, the source of the problem was very different. We were confused when Firebase showed the last transaction as signalR. But we see the real problem now. Thanks

https://github.com/patchthecode/JTAppleCalendar/issues/1385

moozzyk commented 1 year ago

Thanks for the update.