search

mop-tracker / mop

Stock market tracker for hackers.
MIT License
1.98k stars 302 forks source link

Currency symbol #93

Closed LinuxLinksdotcom closed 2 years ago

LinuxLinksdotcom commented 2 years ago

When adding tickers from non-US exchanges, the stock price is incorrectly shown as $

For example, AZN.L (listed on the FTSE) should be shown with a price in £ not $.

brandleesee commented 2 years ago

@LinuxLinksdotcom Indeed! Fixed here: https://github.com/mop-tracker/mop/commit/c5e6a3c2e2db689034e73a589c57767e0dc4ac29 Can you please check from your end? I am closing this but if issue persists will re-open again.

LinuxLinksdotcom commented 2 years ago

The commit doesn't fix the bug.

The issue is that the wrong currency is displayed for non-US stocks for columns such as Last, Change, Open, Low, High etc.

AZN.L still shows as a dollar price when it's £, AZN.ST still shows as $ when it's priced in Swedish Krona etc.

brandleesee commented 2 years ago

Fixed: https://github.com/mop-tracker/mop/commit/81febd7d51491205ae3b6bb2844721cb79623665 (pound in Yahoo Finance is not GBP but GBp - https://finance.yahoo.com/quote/AZN.L?p=AZN.L&.tsrc=fin-srch)

Swedish currency added.

Thank you for the report, please check from your end. Will reopen if the issue persists.

LinuxLinksdotcom commented 2 years ago

Bug is not fixed just yet.

It's GBp, the lower case p means pence, not pounds.

You're showing the prices in pounds, not pence. For example, your program is showing AZN.L has a share price of £8479.00. It's either 8479.00p or £84.79, not £8479.00. Same applies to the other columns (change, open, low etc)

brandleesee commented 2 years ago

Thank you for the clarification.

Fixed here: https://github.com/mop-tracker/mop/commit/6d416e9e3675d899bc574db06ebda66580b74184

TBH, I am not really happy with p8479.00 but am not keen on changing the position of the currency symbol in order to respect the proper written format.

Alternatively, I could change it to £p example £p8479.00. This makes more sense to me. What's your take, @LinuxLinksdotcom ?

LinuxLinksdotcom commented 2 years ago

Personally I prefer p8479.00 to £p8479.00. I've never seen a UK stock shown with a price prefixed £p -- poundpence doesn't mean anything.

brandleesee commented 2 years ago

I am in agreement with your rationale. Shall leave it as pXXXX.xx. Thank you very much for the testing. Anything you see off, please report back.