mopidy / mopidy-gmusic

DEPRECATED (Mopidy extension for playing music from Google Play Music)
https://mopidy.com
Apache License 2.0
214 stars 60 forks source link

Use Mopidy's command API for initial auth #221

Closed jacobobryant closed 5 years ago

jacobobryant commented 5 years ago

This will provide a mopidy gmusic login command for getting the refresh token.

jacobobryant commented 5 years ago

I didn't update the readme fyi, so that would need to be done at some point (after the next release to pypi?).

belak commented 5 years ago

I like this! Thanks for taking the time to submit it. I'm super busy for the next month or so but I'll try and do what I can.

jacobobryant commented 5 years ago

Sounds good! Happy to make changes/help in any way I can, just let me know. I see the CI tests failed, though it looks like the tests are just out of date (?).

belak commented 5 years ago

There's some flake8 stuff to clean up that seems related to this change, but yes... the tests are broken currently.

https://travis-ci.org/mopidy/mopidy-gmusic/jobs/567119009

jacobobryant commented 5 years ago

Question about the deviceid config key (and the block explaining it in the README). I didn't have to specify a deviceid (I've also verified that playback works), and mopidy-gmusic didn't output a list of registered devices either (as the README says it would). Is the device id bit just out of date and should be removed?

jacobobryant commented 5 years ago

Doh, thought the merge button might show up after hitting "close pull request". Obviously I don't have access to the merge button since it's not my repo ;)

mrki0620 commented 5 years ago

Hi to all. I'm trying to perform the initial authentication to my google music account with the mopidy-gmusic extension. Do I understand the steps correctly?: 1) Using mopidy as a service I should first install the mopidy-gmusic extension in context of a "mopidy" user and take the master branch version (where the "mopidy gmusic login" command for getting the refresh token is provided) sudo -u mopidy pip install https://github.com/mopidy/mopidy-gmusic/archive/master.zip

2) Add configuration to /etc/mopidy/mopidy.conf (what should than be configuration settings added?) [gmusic] deviceid = 0123456789abcdef deviceid = mac all_access = true ... 3) Run the "mopidy gmusic login" command or (sudo mopidyctl gmusic login) What are the correct steps to get this working? Many thanks for your help

jacobobryant commented 5 years ago

@mrki0620 looks from the other thread like you got this figured out already--but FYI the mopidy gmusic login command won't be on the master branch till this PR is merged. In the mean time, the command could be used by installing the branch in my fork (pip install https://github.com/jacobobryant/mopidy-gmusic/archive/master.zip)

jodal commented 5 years ago

Sorry we left this hanging! This is a really nice improvement, exactly the kind of thing the Commands API is intended for. Let's get this released quickly :-)

jacobobryant commented 5 years ago

Thanks!