mopidy / mopidy-gmusic

DEPRECATED (Mopidy extension for playing music from Google Play Music)
https://mopidy.com
Apache License 2.0
214 stars 60 forks source link

Update project setup and port to Python 3 #227

Closed jodal closed 4 years ago

jodal commented 4 years ago

Fixes #226

belak commented 4 years ago

Really wish this didn't change pretty much every quote in the project - makes it harder to tell what changes are actually related to Python 3... in any sense, I'll aim to get through this today.

Thanks for submitting this!

jodal commented 4 years ago

The reformatting with Black is a separate commit, so you can view the changes commit by commit to get a feeling for the changes.

belak commented 4 years ago

Just the small comment, otherwise it looks good. Looks like the actual port was fairly painless.

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6767176). Click here to learn what that means. The diff coverage is 4.1%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #227   +/-   ##
=========================================
  Coverage          ?   20.02%           
=========================================
  Files             ?        9           
  Lines             ?      754           
  Branches          ?        0           
=========================================
  Hits              ?      151           
  Misses            ?      603           
  Partials          ?        0
Impacted Files Coverage Δ
mopidy_gmusic/translator.py 18.91% <0%> (ø)
mopidy_gmusic/commands.py 0% <0%> (ø)
mopidy_gmusic/playlists.py 17.94% <0%> (ø)
mopidy_gmusic/playback.py 54.54% <0%> (ø)
mopidy_gmusic/library.py 10.75% <2.67%> (ø)
mopidy_gmusic/scrobbler_frontend.py 45% <25%> (ø)
mopidy_gmusic/session.py 43.63% <25%> (ø)
mopidy_gmusic/backend.py 31.66% <9.09%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6767176...04bd7cd. Read the comment docs.