search

mopidy / mopidy-gmusic

DEPRECATED (Mopidy extension for playing music from Google Play Music)
https://mopidy.com
Apache License 2.0
214 stars 60 forks source link

Successful login, but no results found when search. #229

Closed Deep-Six closed 4 years ago

Deep-Six commented 4 years ago

Hi, I am receiving this error, when I attempt to search my gmusic library, no results are shown in ncmpcpp as a result.

ERROR 2020-01-22 13:47:24,594 [1011082:Core-9] mopidy.core.library GMusicBackend backend caused an exception. Traceback (most recent call last): File "/usr/lib/python3.8/site-packages/mopidy/core/library.py", line 17, in _backend_error_handling yield File "/usr/lib/python3.8/site-packages/mopidy/core/library.py", line 316, in search result = future.get() File "/usr/lib/python3.8/site-packages/pykka/_threading.py", line 45, in get _compat.reraise(self._data['exc_info']) File "/usr/lib/python3.8/site-packages/pykka/_compat/init.py", line 29, in reraise raise value File "/usr/lib/python3.8/site-packages/pykka/_actor.py", line 193, in _actor_loop response = self._handle_receive(envelope.message) File "/usr/lib/python3.8/site-packages/pykka/_actor.py", line 299, in _handle_receive return callee(message.args, **message.kwargs) File "/usr/lib/python3.8/site-packages/mopidy_gmusic/library.py", line 388, in search lib_tracks, lib_artists, lib_albums = self._search_library(query, uris) File "/usr/lib/python3.8/site-packages/mopidy_gmusic/library.py", line 451, in _search_library self._validate_query(query) File "/usr/lib/python3.8/site-packages/mopidy_gmusic/library.py", line 526, in _validatequery for (, values) in query.iteritems(): AttributeError: 'dict' object has no attribute 'iteritems'

kingosticks commented 4 years ago

Thanks, this changed in Python 3 and we missed it during the port.

kingosticks commented 4 years ago

Running 2to3 on the codebase shows a lot of redherrings but we should look closer since the tests are not doing much.

NickHu commented 4 years ago

I think I'm getting a similar error - I've just set up mopidy-gmusic, to use with mopidy-mpd and ncmpcpp. I don't have All Access, but I can play tracks I've uploaded only through Browse: Google Play Music/Tracks; if I look in Browse: Google Play Music/Albums or Browse: Google Play Music/Artists, I can see my albums and artists, however trying to access any of those 'folders' yields no tracks.

kingosticks commented 4 years ago

Please check your log for an error traceback similar to the above. https://docs.mopidy.com/en/latest/troubleshooting/ for more help with that.

kingosticks commented 4 years ago

@Deep-Six I am confused, what version of Mopidy-gmusic are you running here? Your line numbers do not match the source in this repo, iteritems isn't used in the latest version. Can you make sure you are running version v4.0.0 and can we see your mopidy deps please.

I've no idea what I was running 2to3 against yesterday, I am going mad.

NickHu commented 4 years ago

Please check your log for an error traceback similar to the above. https://docs.mopidy.com/en/latest/troubleshooting/ for more help with that.

I get no errors or anything notable in the logs with -vvvv:

DEBUG    2020-01-24 09:11:07,673 [24604:MpdSession-18] mopidy_mpd.session
  Request from [::ffff:127.0.0.1]:38138: noidle
DEBUG    2020-01-24 09:11:07,673 [24604:MpdSession-18] mopidy_mpd.session
  Response to [::ffff:127.0.0.1]:38138: OK
DEBUG    2020-01-24 09:11:07,673 [24604:MpdSession-18] mopidy_mpd.session
  Request from [::ffff:127.0.0.1]:38138: lsinfo "Google Play Music/Albums/Radiohead - The Bends"
DEBUG    2020-01-24 09:11:07,674 [24604:GMusicBackend-6] mopidy_gmusic.library
  browse: gmusic:album:B4leblu5yxxyu33q4ij2zs65wuq
DEBUG    2020-01-24 09:11:07,709 [24604:MpdSession-18] mopidy_mpd.session
  Response to [::ffff:127.0.0.1]:38138: OK
DEBUG    2020-01-24 09:11:07,710 [24604:MpdSession-18] mopidy_mpd.session
  Request from [::ffff:127.0.0.1]:38138: idle
kingosticks commented 4 years ago

@NickHu Then your issue is not the same issue that was reported in this bug report. I don't have a Mopidy-Gmusic account but from what I can see, IDs starting with a 'B' signify an all access item and your log shows "gmusic:album:B4leblu5yxxyu33q4ij2zs65wuq". There is a fallback in this case to then find the album tracks in the user library, but the code comment suggests that should only occur for purchased tracks. If you think your album should be displayed then please open a new issue, or post on the user forums.

Im going to close this as I don't believe the original reported issue is present in the latest version. Feel free to re-open if that's not the case, and also include your mopidy deps output.

kingosticks commented 4 years ago

Oh, and the forms are at https://discourse.mopidy.com/

Deep-Six commented 4 years ago

hey @kingosticks I am running an arch platform, aur/mopidy-gmusic 3.0.0-2 (+6 0.00%) (Out-of-date 2019-12-23) (Installed) Mopidy extension for playing music from Google Play Music

kingosticks commented 4 years ago

The only Python 3 compatible release is the latest one (v4.0.0). AUR needs updating. It has already been flagged as out of date so I guess you are waiting on the maintainer. In the meantime, perhaps you can install from pip?